Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggregate metrics by cluster #12

Merged
merged 1 commit into from
Oct 25, 2023
Merged

aggregate metrics by cluster #12

merged 1 commit into from
Oct 25, 2023

Conversation

Keksoj
Copy link
Contributor

@Keksoj Keksoj commented Oct 25, 2023

flatten all metric labels, except the cluster id, by compounding metrics of the same name

With aggregate-backend-metrics = true

# TYPE bytes_out counter
bytes_out{worker="0"} 246
bytes_out{cluster_id="MyCluster",backend_id="the-backend-to-my-app"} 250
bytes_out{cluster_id="MyCluster",backend_id="the-backend-to-my-app-2"} 250
bytes_out{worker="1"} 246
bytes_out{cluster_id="MyCluster",backend_id="the-backend-to-my-app"} 250
bytes_out{cluster_id="MyCluster",backend_id="the-backend-to-my-app-2"} 250
Métriques prometheus de Sōzu, sans agglomération par cluster:

with aggregate-backend-metrics = false

# TYPE bytes_out counter
bytes_out{} 492
bytes_out{cluster_id="MyCluster"} 1000

@Keksoj Keksoj added the enhancement New feature or request label Oct 25, 2023
@Keksoj Keksoj self-assigned this Oct 25, 2023
FlorentinDUBOIS
FlorentinDUBOIS reviewed Oct 25, 2023
View reviewed changes
src/svc/telemetry/prometheus.rs Outdated
}
}

println!("with proxy wide metrics: {:#?}", acc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove println

@Keksoj Keksoj force-pushed the aggregate-metrics-by-worker branch from 9a6b3b0 to 992926a Compare October 25, 2023 08:31
@Keksoj Keksoj force-pushed the aggregate-metrics-by-worker branch from 992926a to 3b26d18 Compare October 25, 2023 08:41
@FlorentinDUBOIS FlorentinDUBOIS merged commit 770a182 into main Oct 25, 2023
8 checks passed
@FlorentinDUBOIS FlorentinDUBOIS deleted the aggregate-metrics-by-worker branch October 25, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentinDUBOIS FlorentinDUBOIS FlorentinDUBOIS approved these changes

@Wonshtrum Wonshtrum Awaiting requested review from Wonshtrum Wonshtrum is a code owner

Assignees

@Keksoj Keksoj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keksoj @FlorentinDUBOIS